[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 04 May 2009 21:37:30 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jpirko@...hat.com
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
jgarzik@...ox.com, shemminger@...ux-foundation.org,
bridge@...ts.linux-foundation.org, fubar@...ibm.com,
bonding-devel@...ts.sourceforge.net, kaber@...sh.net,
mschmidt@...hat.com, dada1@...mosbay.com, ivecera@...hat.com
Subject: Re: [PATCH] net: introduce a list of device addresses
dev_addr_list (v5)
From: Jiri Pirko <jpirko@...hat.com>
Date: Mon, 4 May 2009 13:14:18 +0200
> +static void __hw_addr_del_multiple(struct list_head *to_list,
> + struct list_head *from_list,
> + int addr_len, unsigned char addr_type)
> +{
> + __hw_addr_del_multiple_ii(to_list, from_list, addr_len, addr_type, -1);
> +}
Unused static function, this will create build warnings.
Or, it should :-)
If you plan to use such a function in subsequent patches, add
it in those changes not here.
Otherwise I have no fundamental objection to this patch, nice
work!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists