[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 4 Apr 2010 19:31:42 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Timo Teräs <timo.teras@....fi>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] flow: virtualize flow cache entry methods
On Sun, Apr 04, 2010 at 07:26:36PM +0800, Herbert Xu wrote:
>
> Fine, move key into flow_cache_entry but the rest should still
> work, no?
>
> struct flow_cache_object {
> u16 family;
> u8 dir;
> u32 genid;
> struct flow_cache_ops *ops;
> };
>
> struct flow_cache_entry {
> struct flow_cache_entry *next;
> struct flowi key;
> struct flow_cache_object *obj;
> };
>
> struct xfrm_policy {
> struct flow_cache_object flo;
> ...
> };
OK this doesn't work either as we still have NULL objects for
now. But I still think even if the ops pointer is the only
member in flow_cache_object, it looks better than returning the
nested ops pointer directly from flow_cache_lookup.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists