[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 09 Dec 2010 19:53:15 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: mroos@...ux.ee
Cc: netdev@...r.kernel.org, j@...fi, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] fix hostap registration order
From: Meelis Roos <mroos@...ux.ee>
Date: Fri, 10 Dec 2010 01:19:23 +0200 (EET)
> In 2.6.37-rc4, hostap_pci init gives a WARNING with backtrace telling
> that netif_stop_queue is called before register_netdev. Fix it by moving
> this call after register_netdev. Removes the warning and seems to work,
> but why is the call to netif_stop_queue needed at all after
> register_netdev?
>
> Signed-off-by: Meelis Roos <mroos@...ux.ee>
It should simply not touch the queue state at all at this point.
Your change would add a race. At the moment the device is registered
it can be brought up, and then your code will eroneously modify
the queue state.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists