netdev - Re: [PATCH] net: Fix ip link add netns oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 30 Jan 2011 01:15:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, eswierk@...switch.com, stable@...nel.org
Subject: Re: [PATCH] net: Fix ip link add netns oops

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Sat, 29 Jan 2011 16:57:22 -0800

> 
> Ed Swierk <eswierk@...switch.com> writes:
>> On 2.6.35.7
>>  ip link add link eth0 netns 9999 type macvlan
>> where 9999 is a nonexistent PID triggers an oops and causes all network functions to hang:
>> [10663.821898] BUG: unable to handle kernel NULL pointer dereference at 000000000000006d
>>  [10663.821917] IP: [<ffffffff8149c2fa>] __dev_alloc_name+0x9a/0x170
 ...
> This bug was introduced in:
> commit 81adee47dfb608df3ad0b91d230fb3cef75f0060
> Author: Eric W. Biederman <ebiederm@...stanetworks.com>
> Date:   Sun Nov 8 00:53:51 2009 -0800
> 
>     net: Support specifying the network namespace upon device creation.
...
> Where apparently I forgot to add error handling to the path where we create
> a new network device in a new network namespace, and pass in an invalid pid.
> 
> Cc: stable@...nel.org
> Reported-by: Ed Swierk <eswierk@...switch.com>
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html