lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 26 Jun 2011 17:53:50 +0200
From:	Eric Dumazet <>
Cc:	David Miller <>,
	Herbert Xu <>,
Subject: Re: [PATCH] net_sched: fix dequeuer fairness

Le dimanche 26 juin 2011 à 11:32 -0400, jamal a écrit :
> On Sun, 2011-06-26 at 17:09 +0200, Eric Dumazet wrote:
> > I would just remove the jiffies break, now we have a 64 packets limit...
> > 
> > if (quota >= work || need_resched()) {
> > 	...
> > }
> Seems reasonable to do. Some stats (on two different machines
> at least with dummy) on a system with low # of processes:
> ~80% of the time - we exit the loop because of packet quota
> ~1% for both need_resched and jiffy
> ~19% simply because there were less than quota packets
> Note: we do use a jiffy check on net_rx_action() but i suspect
> we never ever hit it.

This is because of commit 24f8b2385e03a4f.

Prior to this, we could exit very fast from this function, even after
receiving a single packet.

jiffies break is kind of lazy, IMHO ;)

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux - Powered by OpenVZ