netdev - Re: Open vSwitch Design

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Nov 2011 07:36:53 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, jhs@...atatu.com, hadi@...erus.ca,
	jesse@...ira.com, netdev@...r.kernel.org, dev@...nvswitch.org,
	chrisw@...hat.com, herbert@...dor.hengli.com.au,
	john.r.fastabend@...el.com, jpettit@...ira.com,
	Florian Westphal <fw@...len.de>
Subject: Re: Open vSwitch Design

Le vendredi 25 novembre 2011 à 01:25 -0500, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 25 Nov 2011 07:18:03 +0100
> 
> > Le jeudi 24 novembre 2011 à 21:20 -0800, Stephen Hemminger a écrit :
> > 
> >> The problem is that there are two flow classifiers, one in OpenVswitch
> >> in the kernel, and the other in the user space flow manager. I think the
> >> issue is that the two have different code.
> > 
> > We have kind of same duplication in kernel already :)
> > 
> > __skb_get_rxhash() and net/sched/cls_flow.c contain roughly the same
> > logic...
> > 
> > Maybe its time to factorize the thing, eventually use it in a third
> > component (Open vSwitch...)
> 
> Yes.

A third reason to do that anyway is that net/sched/sch_sfb.c should use
__skb_get_rxhash() providing the perturbation itself, and not use the
standard (hashrnd) one ).

Right now, if two flows share same rxhash, the double SFB hash will also
share the same final hash.

(This point was mentioned by Florian Westphal)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html