netdev - Re: [RFCv2 9/9] caif-xshm: Add CAIF driver for Shared memory for M7400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Dec 2011 12:50:06 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Sjur Brændeland 
	<sjur.brandeland@...ricsson.com>
Cc:	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>, sjurbren@...il.com,
	netdev@...r.kernel.org
Subject: Re: [RFCv2 9/9] caif-xshm: Add CAIF driver for Shared memory for
 M7400

A few minor comments follow. They're basically identical to some of my
comments on v1 of 8/9 ("xshm: Makefile and Kconfig for M7400 Shared
Memory Drivers"). I guess I just didn't spot these the first time.

On Tue, 2011-11-29 at 20:39 +0100, Sjur Brændeland wrote:
> This patch introduces a caif shared memory link layer driver
> for ST-Ericsson's Thor M7400 LTE modem.
> 
> M7400 uses a ring-buffer in shared memory for transporting data from the modem.
> Each ring-buffer element contains an array of caif frames. caif_xshm calls
> napi_schedule() when receiving notification about incoming data.
> The napi-poll function copies data from the ring-buffer to SKBs until
> ring-buffer is empty, or quota is exceeded.
> 
> If transmit ring-buffer is full, it also uses napi for scheduling transmission
> of queued transmit buffer.
> 
> Signed-off-by: Sjur Brændeland <sjur.brandeland@...ricsson.com>
> cc: netdev@...r.kernel.org
> ---
>  drivers/net/caif/Kconfig     |   10 +
>  drivers/net/caif/Makefile    |    1 +
>  drivers/net/caif/caif_xshm.c |  935 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 946 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/caif/caif_xshm.c
> 
> diff --git a/drivers/net/caif/Kconfig b/drivers/net/caif/Kconfig
> index abf4d7a..2861374 100644
> --- a/drivers/net/caif/Kconfig
> +++ b/drivers/net/caif/Kconfig
> @@ -47,3 +47,13 @@ config CAIF_HSI
>         The caif low level driver for CAIF over HSI.
>         Be aware that if you enable this then you also need to
>         enable a low-level HSI driver.
> +
> +config CAIF_XSHM
> +	tristate "CAIF external memory protocol driver"
> +	depends on XSHM && CAIF
> +	default n
> +	---help---
> +	Say "yes" if you want to support CAIF over External Shared Memory (XSHM)

"Say Y"?

> +	IPC mechanism (e.g. over Chip to Chip).
> +	This will normally be built-in, loadable module is used for testing.

Perhaps something like: "Only say M here if you want to test CAIF over
XSHM and need to load and unload its module."?

> +	If unsure say N.
[...]


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html