netdev - Re: [PATCH net-next 1/2] net_sched: sfq: fix mem alloc error recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Jan 2012 14:13:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net_sched: sfq: fix mem alloc error
 recovery

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 04 Jan 2012 17:22:24 +0100

> Since commit 817fb15dfd98 (net_sched: sfq: allow divisor to be a
> parameter), we can leave perturbation timer armed if a memory allocation
> error aborts sfq_init().
> 
> Memory containing active struct timer_list is freed and kernel can
> crash.
> 
> Call sfq_destroy() from sfq_init() to properly dismantle qdisc.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html