lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 May 2012 09:59:21 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Hiroaki SHIMODA <shimoda.hiroaki@...il.com> Cc: davem@...emloft.net, therbert@...gle.com, denys@...p.net.lb, netdev@...r.kernel.org Subject: Re: [PATCH net 2/3] bql: Avoid unneeded limit decrement. On Thu, 2012-05-31 at 07:25 +0900, Hiroaki SHIMODA wrote: ... > Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com> > Cc: Tom Herbert <therbert@...gle.com> > Cc: Eric Dumazet <eric.dumazet@...il.com> > Cc: Denys Fedoryshchenko <denys@...p.net.lb> > --- > lib/dynamic_queue_limits.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/dynamic_queue_limits.c b/lib/dynamic_queue_limits.c > index c87eb76..0fafa77 100644 > --- a/lib/dynamic_queue_limits.c > +++ b/lib/dynamic_queue_limits.c > @@ -11,12 +11,14 @@ > #include <linux/dynamic_queue_limits.h> > > #define POSDIFF(A, B) ((int)((A) - (B)) > 0 ? (A) - (B) : 0) > +#define AFTER_EQ(A, B) ((int)((A) - (B)) >= 0) > > /* Records completed count and recalculates the queue limit */ > void dql_completed(struct dql *dql, unsigned int count) > { > unsigned int inprogress, prev_inprogress, limit; > - unsigned int ovlimit, all_prev_completed, completed; > + unsigned int ovlimit, completed; > + bool all_prev_completed; > > /* Can't complete more than what's in queue */ > BUG_ON(count > dql->num_queued - dql->num_completed); > @@ -26,7 +28,7 @@ void dql_completed(struct dql *dql, unsigned int count) > ovlimit = POSDIFF(dql->num_queued - dql->num_completed, limit); > inprogress = dql->num_queued - completed; > prev_inprogress = dql->prev_num_queued - dql->num_completed; > - all_prev_completed = POSDIFF(completed, dql->prev_num_queued); > + all_prev_completed = AFTER_EQ(completed, dql->prev_num_queued); > > if ((ovlimit && !inprogress) || > (dql->prev_ovlimit && all_prev_completed)) { Acked-by: Eric Dumazet <edumazet@...gle.com> Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists