netdev - Re: [PATCH 2/2] Fix phy_attach - forward dev_flags for phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jan 2013 15:40:36 +0100
From:	Florian Fainelli <florian@...nwrt.org>
To:	Kosta Zertsekel <konszert@...vell.com>
CC:	netdev@...r.kernel.org, zertsekel@...il.com, andrew@...n.ch,
	benavi@...vell.com, linux-arm-kernel@...ts.infradead.org,
	alior@...vell.com
Subject: Re: [PATCH 2/2] Fix phy_attach - forward dev_flags for phy_attach

Le 01/10/13 13:00, Kosta Zertsekel a écrit :
> Change-Id: Ie3191f95c36eada6d0c673460de5393641128182
> ---
>   drivers/net/ethernet/marvell/pxa168_eth.c | 2 +-
>   net/dsa/slave.c                           | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

I think that you should have actually two patches, one for pxa168_eth 
and one for net/dsa/slave.c.

Also, please prefix your patches with what was usually used on these 
files before: "pxa168_eth:" and "net: dsa:" respectively.

By the way, most, if not all of the phy_connect() users in 
drivers/net/ethernet/ also do not ensure they pass the phy device flags, 
so you might want to fix this globally and not just for Marvell driver.

Thanks.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html