netdev - RE: [PATCH 2/2] Fix phy_attach - forward dev_flags for phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jan 2013 17:57:25 +0200
From:	Kosta Zertsekel <konszert@...vell.com>
To:	Florian Fainelli <florian@...nwrt.org>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"zertsekel@...il.com" <zertsekel@...il.com>,
	"andrew@...n.ch" <andrew@...n.ch>,
	Eran Ben-Avi <benavi@...vell.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Lior Amsalem <alior@...vell.com>
Subject: RE: [PATCH 2/2] Fix phy_attach - forward dev_flags for phy_attach

> By the way, most, if not all of the phy_connect() users in drivers/net/ethernet/ also do not ensure they pass the phy device flags, so you might 

want to fix this globally and not just for Marvell driver.
Indeed, phy_connect() mostly just pass zero intead of phy_dev->dev_flags.
But, I think, the guy that calls phy_connect() in its driver should know what he does, and,
probably, we should rely on him knowing his stuff.
The only evidence of the bug is when phy_dev->dev_flags was actually changed by PHY fixup callback
(see dns323-setup.c for example) and was *not* propagated to phy_connect() or phy_attach() as in pxa168_eth.c phy_init().
The code conforming to the former should be fixed IMHO.

Thanks,
--- KostaZ