netdev - Re: [PATCH net-next] ipip: do not use 'err' variable for setting return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2013 03:20:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sakiwit@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipip: do not use 'err' variable for setting
 return value

From: Jean Sacren <sakiwit@...il.com>
Date: Tue, 15 Jan 2013 01:14:10 -0700

> It's a bit confusing to set 'err' variable inside and outside of the
> block for the return value of ipip_err(). We don't even need this
> variable, so clean it all up to spare declaration as well as bunch of
> unnecessary initializations and jumps.
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>

It makes the non-error path straight line code.

The code as-is is fine, and I'm not applying this patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html