[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 2 Feb 2013 02:04:14 +0100
From: Michał Mirosław <mirqus@...il.com>
To: Vlad Yasevich <vyasevic@...hat.com>
Cc: shemminger@...tta.com, bridge@...ts.linux-foundation.org,
davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v9 net-next 05/12] bridge: Add the ability to configure pvid
2013/2/1 Vlad Yasevich <vyasevic@...hat.com>:
> A user may designate a certain vlan as PVID. This means that
> any ingress frame that does not contain a vlan tag is assigned to
> this vlan and any forwarding decisions are made with this vlan in mind.
[...]
> struct net_port_vlans {
> u16 port_idx;
> + u16 pvid;
I'm confused about the implementation. I would expect pvid field in
net_bridge_port and adding a tag if it isn't there on ingress path.
The rest would be just like without PVIDs. But here you pvid field to
net_port_vlans, and don't do anything with it in receive nor transmit
path. Does it work? What am I missing?
Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists