netdev - Re: [PATCH] net: Fix inner_network_header assignment in skb-copy.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 1 Feb 2013 17:14:43 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Fix inner_network_header assignment in skb-copy.

On Fri, Feb 1, 2013 at 4:57 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:
> On Fri, Feb 1, 2013 at 7:26 PM, Pravin B Shelar <pshelar@...ira.com> wrote:
>> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
>
> Hi Pravin,
>
> As a general rule of thumb, a commit log should cover these three
> basic things:
>
> 1) What are the end user visible symptoms of this issue (i.e. does it panic,
> does it hang, do applications segfault, etc etc).
>
> 2) Why does this happen?  i.e. explain where the logic error is in the
> existing code base and so forth.
>
> 3) How do we best fix this?   i.e. explain what our options are to fix
> the issue, and why your choice of fixes is technically the best choice.
>
> With no long log whatsoever, your change does not cover any of
> the #1, #2 or #3.  And without that, it also makes review by the
> maintainers more difficult, and reduces the chance that your
> patch will be integrated into mainline.  Can you perhaps resend
> with a more detailed commit log, given the above information?
>

Well its trivial change so I did not wrote commit msg. Anyways I will
send patch with a commit msg.

Thanks,
Pravin.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html