netdev - RE: [PATCH] net: fec: fix the error to get the previous BD entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Sep 2013 01:37:22 +0000
From:	Duan Fugang-B38611 <B38611@...escale.com>
To:	David Miller <davem@...emloft.net>
CC:	Li Frank-B20596 <B20596@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"l.stach@...gutronix.de" <l.stach@...gutronix.de>
Subject: RE: [PATCH] net: fec: fix the error to get the previous BD entry

From: David Miller <davem@...emloft.net>
Data: Saturday, August 31, 2013 5:59 AM

> To: Duan Fugang-B38611
> Cc: Li Frank-B20596; netdev@...r.kernel.org; bhutchings@...arflare.com;
> l.stach@...gutronix.de
> Subject: Re: [PATCH] net: fec: fix the error to get the previous BD entry
> 
> From: Fugang Duan <B38611@...escale.com>
> Date: Fri, 30 Aug 2013 12:35:25 +0800
> 
> > When the current BD is the first BD, the previous BD entry must be the
> > last BD, not "bdp - 1".
> >
> > Add BD entry check to get the previous BD entry correctly.
> >
> > Signed-off-by: Fugang Duan  <B38611@...escale.com>
> 
> The correct fix is to put this logic into fec_enet_get_prevdesc().
> With this current limitation, the function is completely useless.

Due to get tx & rx previous description use the same function fec_enet_get_prevdesc(). If put the logic into fec_enet_get_prevdesc(),
I think it is better to split the function to fec_enet_get_tx_prevdesc(),fec_enet_get_rx_prevdesc().

If you agree it, I will submit one patch to do it.

Thanks,
Andy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html