netdev - Re: [PATCH net-next] natsemi: fix legacy printk() style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Oct 2013 15:33:16 -0700
From:	Joe Perches <joe@...ches.com>
To:	Drew McGowen <quantumdude836@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] natsemi: fix legacy printk() style

On Thu, 2013-10-24 at 21:37 +0000, Drew McGowen wrote:
> Fixed printk() calls to use KERN_* prefix (some were not changed because they
> are continuations of a previous line).
[]
> diff --git a/drivers/net/ethernet/natsemi/natsemi.c b/drivers/net/ethernet/natsemi/natsemi.c
[]
> @@ -814,7 +814,7 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent)
>  #ifndef MODULE
>  	static int printed_version;
>  	if (!printed_version++)
> -		printk(version);
> +		printk(KERN_INFO version);

pr_info_once("%s\n", version);

And remove the trailing newline from version

> @@ -3360,7 +3360,7 @@ static int __init natsemi_init_mod (void)
>  {
>  /* when a module, this is printed whether or not devices are found in probe */
>  #ifdef MODULE
> -	printk(version);
> +	printk(KERN_INFO version);

	pr_info("%s\n", version);

Nicer to use netdev_<level> too.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html