netdev - Re: [PATCH net-next] ns83820: printk() cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Oct 2013 15:38:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Luke C. Jones" <luke.christopher.jones@...il.com>
Cc:	netdev@...r.kernel.org, "Luke C. Jones" <jonesl4@....edu>
Subject: Re: [PATCH net-next] ns83820: printk() cleanup

On Thu, 2013-10-24 at 21:45 +0000, Luke C. Jones wrote:
> In an effort to bring all printk calls up to style standards,
> added log levels to printk calls.
[]
> diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
[]
> @@ -1580,7 +1580,7 @@ static void ns83820_tx_timeout(struct net_device *ndev)
>  	{
>  		u32 isr;
>  		isr = readl(dev->base + ISR);
> -		printk("irq: %08x imr: %08x\n", isr, dev->IMR_cache);
> +		printk(KERN_DEBUG "irq: %08x imr: %08x\n", isr, dev->IMR_cache);

netdev_dbg(ndev, etc...)

> @@ -1603,7 +1603,7 @@ static void ns83820_tx_watch(unsigned long data)
>  	struct ns83820 *dev = PRIV(ndev);
>  
>  #if defined(DEBUG)
> -	printk("ns83820_tx_watch: %u %u %d\n",
> +	printk(KERN_DEBUG "ns83820_tx_watch: %u %u %d\n",
>  		dev->tx_done_idx, dev->tx_free_idx, atomic_read(&dev->nr_tx_skbs)
>  		);

netdev_dbg()

>  #endif
> @@ -2026,7 +2026,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
>  		goto out_free_irq;
>  	}
>  
> -	printk("%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
> +	printk(KERN_INFO "%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
>  		ndev->name, le32_to_cpu(readl(dev->base + 0x22c)),
>  		pci_dev->subsystem_vendor, pci_dev->subsystem_device);
>  

netdev_info()

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html