netdev - Re: [PATCH net] net: fix sysfs symlinks of adjacent devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 19 Sep 2014 10:59:25 +0200
From:	Andres Freund <andres@...razel.de>
To:	Alexander Fomichev <git.user@...il.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Cong Wang <cwang@...pensource.com>,
	Vlad Yasevich <vyasevic@...hat.com>
Subject: Re: [PATCH net] net: fix sysfs symlinks of adjacent devices

Hi,

On 2014-09-12 14:13:46 +0400, Alexander Fomichev wrote:
> From: "Alexander Y. Fomichev" <git.user@...il.com>
> 
> __netdev_adjacent_dev_insert may add adjacent device from another
> namespace. Without proper check it leads to emergence of broken
> symlink from/to device not existing in current namespace.
> Fix: check net_ns is the same before netdev_adjacent_sysfs_add/del
> related to: 4c75431ac3520631f1d9e74aa88407e6374dbbc4
> 

This version, applied on top of 8ba4caf1ee, fixes the bug I had
reported. Not just the testcase, but the actual usage scenario.

I haven't tested David's version, but it doesn't look likely to be
materially different.

Greetings,

Andres Freund
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html