netdev - Re: [PATCH 1/1] altera tse: Fix network-delays and -retransmissions after high throughput.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Apr 2015 12:02:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ennoerlangen@...glemail.com
Cc:	vbridger@...nsource.altera.com, netdev@...r.kernel.org,
	nios2-dev@...ts.rocketboards.org, ennoerlangen@...il.com,
	andreas@...ken.name
Subject: Re: [PATCH 1/1] altera tse: Fix network-delays and
 -retransmissions after high throughput.

From: Andreas Oetken <ennoerlangen@...glemail.com>
Date: Tue, 14 Apr 2015 22:25:26 +0200

> From: Andreas Oetken <andreas@...ken.name>
> 
> Fix bug which occurs when more than <limit> packets are available during napi-poll,
> leading to "delays" and retransmissions on the network.
> 
> Check for (count < limit) before checking the get_rx_status in tse_rx-function. get_rx_status is reading from the response-fifo.
> If there is currently a response in the fifo, reading the last byte of the response pops the value from the fifo.
> If the limit is check as second condition and the limit is reached the fifo is popped but the packet is not processed.
> 
> Signed-off-by: Andreas Oetken <ennoerlangen@...il.com>

Your commit message lines are very long, format them to 80 columns
or less.

> -	while (((rxstatus = priv->dmaops->get_rx_status(priv)) != 0) &&
> -	       (count < limit))  {
> +	/* Check for limit first. get_rx_status is reading the from the
> +	* response-fifo. If there is a currently a response in the fifo,
> +	* reading the last byte of the response pops the value from the fifo.
> +	*/
> +	while ((count < limit) &&
> +		((rxstatus = priv->dmaops->get_rx_status(priv)) != 0)) {

You're corrupted the indentation.

The second line of this while statement should start precisely at
the first column after the openning parenthesis of the first line.
You must use the appropriate number of TAB then SPACE characters
necessary to achieve this.

If you are purely using TAB characters, as you have done here, for
indentation then it is very likely that you have indented things
incorrectly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html