netdev - Re: [PATCH 1/4] stmmac: replace all pr_xxx by their dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2015 09:14:42 -0700
From:	Joe Perches <joe@...ches.com>
To:	LABBE Corentin <clabbe.montjoie@...il.com>
Cc:	peppe.cavallaro@...com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx
 counterpart

On Wed, 2015-09-09 at 15:14 +0200, LABBE Corentin wrote:
> The stmmac driver use lots of pr_xxx functions to print information.
> This is bad since we cannot know which device logs the information.
> (moreover if two stmmac device are present)
[]
> So this patch replace all pr_xxx by their dev_xxx counterpart.

Using
	netdev_<level>(priv->dev, ...
instead of
	dev_<level>(priv->device,

would be more consistent with other ethernet devices.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[]
> @@ -298,7 +298,7 @@ bool stmmac_eee_init(struct stmmac_priv *priv)
>  			 */
>  			spin_lock_irqsave(&priv->lock, flags);
>  			if (priv->eee_active) {
> -				pr_debug("stmmac: disable EEE\n");
> +				dev_dbg(priv->device, "disable EEE\n");

				netdev_dbg(priv->dev, ...)

> @@ -657,10 +657,10 @@ static int stmmac_init_ptp(struct stmmac_priv *priv)
>  		priv->adv_ts = 1;
>  
>  	if (netif_msg_hw(priv) && priv->dma_cap.time_stamp)
> -		pr_debug("IEEE 1588-2002 Time Stamp supported\n");
> +		dev_dbg(priv->device, "IEEE 1588-2002 Time Stamp supported\n");

And these netif_msg_<foo> could be

	if (priv->dma_cap.timestamp)
		netif_dbg(priv, hw, priv->dev, ...);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html