netdev - Re: [patch net-next] bridge: try switchdev op first in __vlan_vid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Oct 2015 09:01:23 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Scott Feldman <sfeldma@...il.com>
Cc:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Ido Schimmel <idosch@...lanox.com>,
	Elad Raz <eladr@...lanox.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	"andrew@...n.ch" <andrew@...n.ch>,
	john fastabend <john.fastabend@...il.com>,
	David Laight <David.Laight@...lab.com>
Subject: Re: [patch net-next] bridge: try switchdev op first in
 __vlan_vid_add/del

Sat, Oct 10, 2015 at 05:20:28AM CEST, sfeldma@...il.com wrote:
>On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot
><vivien.didelot@...oirfairelinux.com> wrote:
>> Hi Jiri,
>>
>> On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@...lanox.com>
>>>
>>> Some drivers need to implement both switchdev vlan ops and
>>> vid_add/kill ndos. For that to work in bridge code, we need to try
>>> switchdev op first when adding/deleting vlan id.
>>
>> Just curious, when would a driver need to have both operations?
>
>Ya, I was kind of curious of that myself. Is this because the driver
>wants to support standalone VLANs using 802.1q module and vconfig, as
>well as bridge vlans?  With the vlan support built into the bridge,
>I've been working under the assumption that 802.1q module (and
>vconfig) aren't needed, and vlans for a bridged and non-bridge port
>can be managed using the "bridge" iproute2 cmd.

Sure, but this is for standalone port device, without being bridged. In
that case if you want to use vlan on top of that, you need these ndos.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html