[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 13 Dec 2015 01:24:13 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: move inline functions to the header file
Hello.
On 04/07/2015 10:33 PM, David Miller wrote:
>>>> The explicitly inline functions belong to the header files, so move
>>>> cpu_to_edmac() and edmac_to_cpu() into the driver header.
>>
>>>> While at it, make these functions return 'u32' instead of '__u32'.
>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>
>>> Then... ummm... remove the inline keyword?
>>
>>> If it's not used anywhere else, that's the thing to do.
>>
>> Results in more code, as I noted in the patch posting that you skipped
>> when replying. At least with gcc 4.7.
>
> That's a compiler bug.
Just tried x86 gcc 5.1.1, same result:
$ size drivers/net/ethernet/renesas/sh_eth.o{~,}
text data bss dec hex filename
23245 1188 0 24433 5f71 drivers/net/ethernet/renesas/sh_eth.o~
23259 1188 0 24447 5f7f drivers/net/ethernet/renesas/sh_eth.o
i.e. +14 bytes of code. :-O
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists