netdev - Re: [PATCH net-next V2 01/10] net/flower: Introduce hardware offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 21:53:35 +0200
From:	"Amir Vadai\"" <amir@...ai.me>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, john.r.fastabend@...el.com,
	jiri@...lanox.com, ogerlitz@...lanox.com, saeedm@...lanox.com,
	hadarh@...lanox.com, ronye@...lanox.com
Subject: Re: [PATCH net-next V2 01/10] net/flower: Introduce hardware offload
 support

On Thu, Mar 03, 2016 at 12:30:33PM -0500, David Miller wrote:
> From: Amir Vadai <amir@...ai.me>
> Date: Thu,  3 Mar 2016 16:55:51 +0200
> 
> > @@ -454,11 +501,13 @@ static int fl_change(struct net *net, struct sk_buff *in_skb,
> >  		     u32 handle, struct nlattr **tca,
> >  		     unsigned long *arg, bool ovr)
> >  {
> > +	struct net_device *dev = tp->q->dev_queue->dev;
> >  	struct cls_fl_head *head = rtnl_dereference(tp->root);
> 
> This variable is not used.
> 
> And the compiler warns about this, and because of this I am pretty sure you
> aren't looking at the compiler output while testing your builds which is a
> big no-no.
My bad. I did a last minute change that left this variable and somehow
missed the warning (though I did compile and test it).
Will fix for v3