[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 13 May 2016 01:56:55 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: aduyck@...antis.com
Cc: netdev@...r.kernel.org, alexander.duyck@...il.com, tgraf@...g.ch,
tom@...bertland.com, jbenc@...hat.com, eric.dumazet@...il.com
Subject: Re: [net-next PATCH v3] udp: Resolve NULL pointer dereference over
flow-based vxlan device
From: Alexander Duyck <aduyck@...antis.com>
Date: Thu, 12 May 2016 16:23:44 -0700
> While testing an OpenStack configuration using VXLANs I saw the following
> call trace:
...
> The following trace is seen when receiving a DHCP request over a flow-based
> VXLAN tunnel. I believe this is caused by the metadata dst having a NULL
> dev value and as a result dev_net(dev) is causing a NULL pointer dereference.
>
> To resolve this I am replacing the check for skb_dst(skb)->dev with just
> skb->dev. This makes sense as the callers of this function are usually in
> the receive path and as such skb->dev should always be populated. In
> addition other functions in the area where these are called are already
> using dev_net(skb->dev) to determine the namespace the UDP packet belongs
> in.
>
> Fixes: 63058308cd55 ("udp: Add udp6_lib_lookup_skb and udp4_lib_lookup_skb")
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>
Applied, thanks!
Powered by blists - more mailing lists