netdev - Re: [net-next PATCH v3] udp: Resolve NULL pointer dereference over flow-based vxlan device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 May 2016 21:43:33 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexander Duyck <aduyck@...antis.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	alexander.duyck@...il.com, tgraf@...g.ch, tom@...bertland.com,
	jbenc@...hat.com
Subject: Re: [net-next PATCH v3] udp: Resolve NULL pointer dereference over
 flow-based vxlan device

On Thu, 2016-05-12 at 16:23 -0700, Alexander Duyck wrote:
> While testing an OpenStack configuration using VXLANs I saw the following
> call trace:

> The following trace is seen when receiving a DHCP request over a flow-based
> VXLAN tunnel.  I believe this is caused by the metadata dst having a NULL
> dev value and as a result dev_net(dev) is causing a NULL pointer dereference.
> 
> To resolve this I am replacing the check for skb_dst(skb)->dev with just
> skb->dev.  This makes sense as the callers of this function are usually in
> the receive path and as such skb->dev should always be populated.  In
> addition other functions in the area where these are called are already
> using dev_net(skb->dev) to determine the namespace the UDP packet belongs
> in.
> 
> Fixes: 63058308cd55 ("udp: Add udp6_lib_lookup_skb and udp4_lib_lookup_skb")
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks ;)