netdev - Re: [PATCH iproute2] tc: flower: Add skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2016 21:26:01 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Amir Vadai <amir@...ai.me>
Cc:	Stephen Hemminger <shemming@...cade.com>, netdev@...r.kernel.org,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Jiri Pirko <jiri@...lanox.com>,
	Hadar Har-Zion <hadarh@...lanox.com>,
	Amir Vadai <amirva@...lanox.com>
Subject: Re: [PATCH iproute2] tc: flower: Add skip_{hw|sw} support

On Mon,  4 Jul 2016 10:34:11 +0300
Amir Vadai <amir@...ai.me> wrote:

> From: Amir Vadai <amirva@...lanox.com>
> 
> On devices that support TC flower offloads, these flags enable a filter to be
> added only to HW or only to SW. skip_sw and skip_hw are mutually exclusive
> flags. By default without any flags, the filter is added to both HW and SW,
> but no error checks are done in case of failure to add to HW.
> With skip-sw, failure to add to HW is treated as an error.
> 
> Here is a sample script that adds 2 filters, one with skip_sw and the other
> with skip_hw flag.
> 
>    # add ingress qdisc
>    tc qdisc add dev enp0s9 ingress
> 
>    # enable hw tc offload.
>    ethtool -K enp0s9 hw-tc-offload on
> 
>    # add a flower filter with skip-sw flag.
>    tc filter add dev enp0s9 protocol ip parent ffff: flower \
> 	   ip_proto 1 indev enp0s9 skip_sw \
> 	   action drop
> 
>    # add a flower filter with skip-hw flag.
>    tc filter add dev enp0s9 protocol ip parent ffff: flower \
> 	   ip_proto 3 indev enp0s9 skip_hw \
> 	   action drop
> 
> Signed-off-by: Amir Vadai <amirva@...lanox.com>

Looks sane. Applied