netdev - Re: [PATCH v4 iproute2 0/6] Add support for vrf keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2016 21:29:23 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v4 iproute2 0/6] Add support for vrf keyword

On Wed, 29 Jun 2016 11:26:56 -0700
David Ahern <dsa@...ulusnetworks.com> wrote:

> Currently the syntax for VRF related commands is rather kludgy and
> inconsistent from one subcommand to another. This set adds support
> for the VRF keyword to the link, address, neigh, and route commands
> to improve the user experience listing data associated with vrfs,
> modifying routes or doing a route lookup.
> 
> v4
> - Stephen's comments about patch 1 also apply to patch 5, so updated it
> v3
> - addressed comments from Stephen
> - added documentation updates to patches 2, 3 and 6
> 
> v2
> - rebased to top of tree
> - all checkpatch warnings are usage lines. The change in these
>   patches is consistent with existing code for usage lines
> 
> David Ahern (6):
>   ip vrf: Add name_is_vrf
>   ip link/addr: Add support for vrf keyword
>   ip neigh: Add support for keyword
>   ip route: Change type mask to bitmask
>   ip vrf: Add ipvrf_get_table
>   ip route: Add support for vrf keyword
> 
>  ip/ip_common.h           |   3 ++
>  ip/ipaddress.c           |  12 ++++-
>  ip/iplink.c              |  15 ++++++-
>  ip/iplink_vrf.c          | 113 +++++++++++++++++++++++++++++++++++++++++++++++
>  ip/ipneigh.c             |  14 +++++-
>  ip/iproute.c             |  43 +++++++++++++++---
>  man/man8/ip-address.8.in |   6 +++
>  man/man8/ip-link.8.in    |  10 +++++
>  man/man8/ip-neighbour.8  |   8 +++-
>  man/man8/ip-route.8.in   |  19 +++++++-
>  10 files changed, 230 insertions(+), 13 deletions(-)
> 

Applied, thanks for cleaning it up.