netdev - RE: [PATCH net-next 04/10] bnxt_en: Added support for Secure Firmware Update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2016 08:16:46 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Michael Chan <michael.chan@...adcom.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 04/10] bnxt_en: Added support for Secure Firmware
 Update

> +	if (bp->hwrm_spec_code < 0x10400)
> +		return -EOPNOTSUPP;
Don't you use defines for these kind of version values?

>  static int bnxt_flash_package_from_file(struct net_device *dev,
...
> +	rc = request_firmware(&fw, filename, &dev->dev);
> +	if (rc != 0) {
If (rc)

> +	if ((install_type & 0xffff) == 0)
> +		install_type >>= 16;
! instead of "== 0". Also, this looks 'magical'.