netdev - Re: [PATCH net-next 6/9] ep93xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 Feb 2017 04:47:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     kbuild-all@...org, "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 6/9] ep93xx_eth: add GRO support

Hi Eric,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-get-rid-of-most-__napi_complete-usages/20170205-022748
config: arm-ep93xx_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/cirrus/ep93xx_eth.c: In function 'ep93xx_poll':
>> drivers/net/ethernet/cirrus/ep93xx_eth.c:319:5: warning: 'rx' is used uninitialized in this function [-Wuninitialized]
     rx = ep93xx_rx(dev, rx, budget);
     ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/rx +319 drivers/net/ethernet/cirrus/ep93xx_eth.c

1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  303  		}
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  304  
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  305  err:
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  306  		ep->rx_pointer = (entry + 1) & (RX_QUEUE_ENTRIES - 1);
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  307  		processed++;
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  308  	}
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  309  
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03  310  	return processed;
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  311  }
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  312  
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03  313  static int ep93xx_poll(struct napi_struct *napi, int budget)
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  314  {
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03  315  	struct ep93xx_priv *ep = container_of(napi, struct ep93xx_priv, napi);
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03  316  	struct net_device *dev = ep->dev;
7b8cc50a drivers/net/ethernet/cirrus/ep93xx_eth.c Eric Dumazet      2017-02-04  317  	int rx;
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  318  
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03 @319  	rx = ep93xx_rx(dev, rx, budget);
7b8cc50a drivers/net/ethernet/cirrus/ep93xx_eth.c Eric Dumazet      2017-02-04  320  	if ((rx < budget) && napi_complete_done(napi, rx)) {
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  321  		spin_lock_irq(&ep->rx_lock);
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  322  		wrl(ep, REG_INTEN, REG_INTEN_TX | REG_INTEN_RX);
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  323  		spin_unlock_irq(&ep->rx_lock);
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  324  	}
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  325  
1827d2e9 drivers/net/arm/ep93xx_eth.c             David S. Miller   2010-05-03  326  	if (rx) {
1827d2e9 drivers/net/arm/ep93xx_eth.c             David S. Miller   2010-05-03  327  		wrw(ep, REG_RXDENQ, rx);

:::::: The code at line 319 was first introduced by commit
:::::: bea3348eef27e6044b6161fd04c3152215f96411 [NET]: Make NAPI polling independent of struct net_device objects.

:::::: TO: Stephen Hemminger <shemminger@...ux-foundation.org>
:::::: CC: David S. Miller <davem@...set.davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (15664 bytes)