netdev - Re: [PATCH net-next 7/9] skge: use napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Feb 2017 13:44:18 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 7/9] skge: use napi_complete_done()

On Sat,  4 Feb 2017 10:20:36 -0800
Eric Dumazet <edumazet@...gle.com> wrote:

>  
> -static int skge_poll(struct napi_struct *napi, int to_do)
> +static int skge_poll(struct napi_struct *napi, int budget)

Ok, but renaming parameter is not really necessary.

> -	if (work_done < to_do) {
> +	if ((work_done < budget) && napi_complete_done(napi, work_done)) {
>  		unsigned long flags;

Parenthesis around work_done < budget are unnecessary.

Other than that it looks fine.