netdev - Re: [PATCH 1/3] fix kcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 05 Dec 2017 18:40:47 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     viro@...IV.linux.org.uk
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] fix kcm_clone()

From: Al Viro <viro@...IV.linux.org.uk>
Date: Tue, 5 Dec 2017 23:27:57 +0000

> 1) it's fput() or sock_release(), not both
> 2) don't do fd_install() until the last failure exit.
> 3) not a bug per se, but... don't attach socket to struct file
>    until it's set up.
> 
> Take reserving descriptor into the caller, move fd_install() to the
> caller, sanitize failure exits and calling conventions.
> 
> Cc: stable@...r.kernel.org # v4.6+
> Acked-by: Tom Herbert <tom@...bertland.com>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Applied.