netdev - Re: [PATCH 3/3] make sock_alloc_file() do sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 05 Dec 2017 18:41:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     viro@...IV.linux.org.uk
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] make sock_alloc_file() do sock_release() on
 failures

From: Al Viro <viro@...IV.linux.org.uk>
Date: Tue, 5 Dec 2017 23:29:09 +0000

> This changes calling conventions (and simplifies the hell out
> the callers).  New rules: once struct socket had been passed
> to sock_alloc_file(), it's been consumed either by struct file
> or by sock_release() done by sock_alloc_file().  Either way
> the caller should not do sock_release() after that point.
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Applied.