netdev - Re: [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 11:13:49 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     William Tu <u9012063@...il.com>
Cc:     netdev@...r.kernel.org, pshelar@....org
Subject: Re: [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II
 support

Looks much better.

On Wed, 17 Jan 2018 09:32:51 -0800, William Tu wrote:
> +	OVS_ERSPAN_OPT_IDX,	/* be32 index */

Why don't you convert this to u32 while passing to/from user space?

> +	[OVS_ERSPAN_OPT_IDX]	= { .len = sizeof(u32) },

sizeof(__be32) but see above.

Thanks,

 Jiri