netdev - Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 16:22:50 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bridge: return boolean instead of integer in
 br_multicast_is_router

On Thu, 18 Jan 2018 17:37:45 -0600
"Gustavo A. R. Silva" <garsilva@...eddedor.com> wrote:

> Return statements in functions returning bool should use
> true/false instead of 1/0.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

LGTM

Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is not enabled")
Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>