netdev - Re: [PATCH] slip: Check if rstate is initialized before uncompressing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Apr 2018 10:03:16 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tejaswit@...eaurora.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] slip: Check if rstate is initialized before
 uncompressing

From: tejaswit@...eaurora.org
Date: Tue, 10 Apr 2018 11:28:10 +0530

> On 2018-04-09 20:34, David Miller wrote:
>> From: Tejaswi Tanikella <tejaswit@...eaurora.org>
>> Date: Mon, 9 Apr 2018 14:23:49 +0530
>> 
>>> @@ -673,6 +677,7 @@ struct slcompress *
>>>  	if (cs->cs_tcp.doff > 5)
>>>  	  memcpy(cs->cs_tcpopt, icp + ihl*4 + sizeof(struct tcphdr),
>>>  	  (cs->cs_tcp.doff - 5) * 4);
>>>  	cs->cs_hsize = ihl*2 + cs->cs_tcp.doff*2;
>>> +	cs->initialized = 1;
>>>  	/* Put headers back on packet
>>  ...
>>>  struct cstate {
>>>  	byte_t	cs_this;	/* connection id number (xmit) */
>>> +	byte_t	initialized;	/* non-zero if initialized */
>> Please use 'bool' and true/false for 'initialized'.
> 
> Made the changes.

Please, when you are asked to fix a patch, post it as a new posting
with '[PATCH v2 net] slip: ...' in the subject line.

And also not as an attachment, all patches must be inline.

Thank you.