netdev - Re: [PATCH net] mlxsw: pci: Only issue reset when system is ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Mar 2020 20:24:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [PATCH net] mlxsw: pci: Only issue reset when system is ready

From: Ido Schimmel <idosch@...sch.org>
Date: Thu, 19 Mar 2020 13:25:39 +0200

> From: Ido Schimmel <idosch@...lanox.com>
> 
> During initialization the driver issues a software reset command and
> then waits for the system status to change back to "ready" state.
> 
> However, before issuing the reset command the driver does not check that
> the system is actually in "ready" state. On Spectrum-{1,2} systems this
> was always the case as the hardware initialization time is very short.
> On Spectrum-3 systems this is no longer the case. This results in the
> software reset command timing-out and the driver failing to load:
> 
> [ 6.347591] mlxsw_spectrum3 0000:06:00.0: Cmd exec timed-out (opcode=40(ACCESS_REG),opcode_mod=0,in_mod=0)
> [ 6.358382] mlxsw_spectrum3 0000:06:00.0: Reg cmd access failed (reg_id=9023(mrsr),type=write)
> [ 6.368028] mlxsw_spectrum3 0000:06:00.0: cannot register bus device
> [ 6.375274] mlxsw_spectrum3: probe of 0000:06:00.0 failed with error -110
> 
> Fix this by waiting for the system to become ready both before issuing
> the reset command and afterwards. In case of failure, print the last
> system status to aid in debugging.
> 
> Fixes: da382875c616 ("mlxsw: spectrum: Extend to support Spectrum-3 ASIC")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for -stable.