netdev - Re: [PATCH net-next] net: sched: Do not assume RTNL is held in tunnel key action helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Mar 2020 20:26:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, jiri@...lanox.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, vladbu@...lanox.com,
        mlxsw@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net-next] net: sched: Do not assume RTNL is held in
 tunnel key action helpers

From: Ido Schimmel <idosch@...sch.org>
Date: Thu, 19 Mar 2020 13:33:10 +0200

> From: Ido Schimmel <idosch@...lanox.com>
> 
> The cited commit removed RTNL from tc_setup_flow_action(), but the
> function calls two tunnel key action helpers that use rtnl_dereference()
> to fetch the action's parameters. This leads to "suspicious RCU usage"
> warnings [1][2].
> 
> Change the helpers to use rcu_dereference_protected() while requiring
> the action's lock to be held. This is safe because the two helpers are
> only called from tc_setup_flow_action() which acquires the lock.
 ...
> Fixes: b15e7a6e8d31 ("net: sched: don't take rtnl lock during flow_action setup")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> Reviewed-by: Vlad Buslov <vladbu@...lanox.com>

Applied, thank you.