netdev - Re: [PATCH] FYI 6.4 xfrm_prepare_input/xfrm_inner_mode_encap_remove WARN_ON hit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 1 Jul 2023 15:51:29 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Maciej Żenczykowski <maze@...gle.com>
Cc: Maciej Żenczykowski <zenczykowski@...il.com>,
	Linux Network Development Mailing List <netdev@...r.kernel.org>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	Benedict Wong <benedictwong@...gle.com>,
	Lorenzo Colitti <lorenzo@...gle.com>, Yan Yan <evitayan@...gle.com>
Subject: Re: [PATCH] FYI 6.4 xfrm_prepare_input/xfrm_inner_mode_encap_remove
 WARN_ON hit - related to ESPinUDP

On Fri, Jun 30, 2023 at 08:37:58AM -0700, Maciej Żenczykowski wrote:
> Steffan, this isn't of course a patch meant for inclusion, instead just a WARN_ON hit report.
> The patch is simply what prints the following extra info:
> 
> xfrm_prepare_input: XFRM_MODE_SKB_CB(skb)->protocol: 17
> xfrm_inner_mode_encap_remove: x->props.mode: 1 XFRM_MODE_SKB_SB(skb)->protocol:17

This seems to make no sense.  UDP encapsulation is supposed to sit
on the outside of ESP.  So by the time we hit xfrm_input it should
be lone gone.  On the inside of the packet, as it's tunnel mode we
should have either IPIP or IPV6, definitely not UDP.

Are you able to reduce this to a set of "ip xfrm" commands that I
can use to reproduce this?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt