netdev - Re: [net-next v7 2/4] net: wwan: t7xx: Add sysfs attribute for device state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri,  2 Feb 2024 10:16:12 +0800
From: Jinjian Song <songjinjian@...mail.com>
To: jiri@...nulli.us
Cc: alan.zhang1@...ocom.com,
	angel.huang@...ocom.com,
	chandrashekar.devegowda@...el.com,
	chiranjeevi.rapolu@...ux.intel.com,
	danielwinkler@...gle.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	felix.yan@...ocom.com,
	freddy.lin@...ocom.com,
	haijun.liu@...iatek.com,
	jinjian.song@...ocom.com,
	joey.zhao@...ocom.com,
	johannes@...solutions.net,
	kuba@...nel.org,
	letitia.tsai@...com,
	linux-kernel@...r.kernel.com,
	liuqf@...ocom.com,
	loic.poulain@...aro.org,
	m.chetan.kumar@...ux.intel.com,
	netdev@...r.kernel.org,
	nmarupaka@...gle.com,
	pabeni@...hat.com,
	pin-hao.huang@...com,
	ricardo.martinez@...ux.intel.com,
	ryazanov.s.a@...il.com,
	songjinjian@...mail.com,
	vsankar@...ovo.com,
	zhangrc@...ocom.com
Subject: Re: [net-next v7 2/4] net: wwan: t7xx: Add sysfs attribute for device state machine

>Thu, Feb 01, 2024 at 04:13:38PM CET, songjinjian@...mail.com wrote:
>>From: Jinjian Song <jinjian.song@...ocom.com>
>>
>>Add support for userspace to get/set the device mode, device's state machine
>>changes between (UNKNOWN/READY/RESET/FASTBOOT_DL_MODE/FASTBOOT_DUMP_MODE).
>>
>>diff --git a/Documentation/networking/device_drivers/wwan/t7xx.rst b/Documentation/networking/device_drivers/wwan/t7xx.rst
>>index dd5b731957ca..d13624a52d8b 100644
>>--- a/Documentation/networking/device_drivers/wwan/t7xx.rst
>>+++ b/Documentation/networking/device_drivers/wwan/t7xx.rst
>>@@ -39,6 +39,34 @@ command and receive response:
>> 
>>+supports read and write operations.
>>+
>>+Device mode:
>>+
>>+- ``UNKNOW`` represents that device in unknown status
>
>should be "unknown", missing "n".
>
>Btw, why are you using capitals for the mode names?

Thanks, let me change it to lowercase and modify the word. 
Previously considering it represents a state machine and with udev to report the state.

>>+- ``READY`` represents that device in ready status
>>+- ``RESET`` represents that device in reset status
>>+- ``FASTBOOT_DL_SWITCHING`` represents that device in fastboot switching status
>>+- ``FASTBOOT_DL_MODE`` represents that device in fastboot download status
>>+- ``FASTBOOT_DL_DUMP_MODE`` represents that device in fastboot dump status
>>+
>>+Read from userspace to get the current device mode.
>>+
>>+::
>>+  $ cat /sys/bus/pci/devices/${bdf}/t7xx_mode
>>+
>>+Write from userspace to set the device mode.
>>+
>>+::
>>+  $ echo FASTBOOT_DL_SWITCHING > /sys/bus/pci/devices/${bdf}/t7xx_mode
>>+
>>+static const char * const mode_names[] = {
>
>t7xx_mode_names

Let me rename it.

Best Regards,
Jinjian