netdev - Re: [net-next v7 4/4] net: wwan: t7xx: Add fastboot WWAN port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri,  2 Feb 2024 10:17:08 +0800
From: Jinjian Song <songjinjian@...mail.com>
To: jiri@...nulli.us
Cc: alan.zhang1@...ocom.com,
	angel.huang@...ocom.com,
	chandrashekar.devegowda@...el.com,
	chiranjeevi.rapolu@...ux.intel.com,
	danielwinkler@...gle.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	felix.yan@...ocom.com,
	freddy.lin@...ocom.com,
	haijun.liu@...iatek.com,
	jinjian.song@...ocom.com,
	joey.zhao@...ocom.com,
	johannes@...solutions.net,
	kuba@...nel.org,
	letitia.tsai@...com,
	linux-kernel@...r.kernel.com,
	liuqf@...ocom.com,
	loic.poulain@...aro.org,
	m.chetan.kumar@...ux.intel.com,
	netdev@...r.kernel.org,
	nmarupaka@...gle.com,
	pabeni@...hat.com,
	pin-hao.huang@...com,
	ricardo.martinez@...ux.intel.com,
	ryazanov.s.a@...il.com,
	songjinjian@...mail.com,
	vsankar@...ovo.com,
	zhangrc@...ocom.com
Subject: Re: [net-next v7 4/4] net: wwan: t7xx: Add fastboot WWAN port

>Thu, Feb 01, 2024 at 04:13:40PM CET, songjinjian@...mail.com wrote:
>>From: Jinjian Song <jinjian.song@...ocom.com>
>
>[...]
>
>>+static void t7xx_port_wwan_create(struct t7xx_port *port)
>>+{
>>+	const struct t7xx_port_conf *port_conf = port->port_conf;
>>+	unsigned int header_len = sizeof(struct ccci_header), mtu;
>>+	struct wwan_port_caps caps;
>>+
>>+	if (!port->wwan.wwan_port) {
>>+		mtu = t7xx_get_port_mtu(port);
>>+		caps.frag_len = mtu - header_len;
>>+		caps.headroom_len = header_len;
>>+		port->wwan.wwan_port = wwan_create_port(port->dev, port_conf->port_type,
>>+							&wwan_ops, &caps, port);
>>+		if (IS_ERR(port->wwan.wwan_port))
>>+			dev_err(port->dev, "Unable to create WWWAN port %s", port_conf->name);
>
>To many "W"s.

Thanks, let me change that.

>>+	}
>>+}
>
>[...]
>
>

Best Regards,
Jinjian