linux-cve-announce - CVE-2023-52492: dmaengine: fix NULL pointer in channel unregistration function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240229155245.1571576-33-lee@kernel.org>
Date: Thu, 29 Feb 2024 15:52:52 +0000
From: Lee Jones <lee@...nel.org>
To: linux-cve-announce@...r.kernel.org
Cc: Lee Jones <lee@...nel.org>
Subject: CVE-2023-52492: dmaengine: fix NULL pointer in channel unregistration function

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

dmaengine: fix NULL pointer in channel unregistration function

__dma_async_device_channel_register() can fail. In case of failure,
chan->local is freed (with free_percpu()), and chan->local is nullified.
When dma_async_device_unregister() is called (because of managed API or
intentionally by DMA controller driver), channels are unconditionally
unregistered, leading to this NULL pointer:
[    1.318693] Unable to handle kernel NULL pointer dereference at virtual address 00000000000000d0
[...]
[    1.484499] Call trace:
[    1.486930]  device_del+0x40/0x394
[    1.490314]  device_unregister+0x20/0x7c
[    1.494220]  __dma_async_device_channel_unregister+0x68/0xc0

Look at dma_async_device_register() function error path, channel device
unregistration is done only if chan->local is not NULL.

Then add the same condition at the beginning of
__dma_async_device_channel_unregister() function, to avoid NULL pointer
issue whatever the API used to reach this function.

The Linux kernel CVE team has assigned CVE-2023-52492 to this issue.

Affected and fixed versions
===========================

	Issue introduced in 5.6 with commit d2fb0a043838 and fixed in 5.10.210 with commit 9de69732dde4
	Issue introduced in 5.6 with commit d2fb0a043838 and fixed in 5.15.149 with commit 047fce470412
	Issue introduced in 5.6 with commit d2fb0a043838 and fixed in 6.1.76 with commit 2ab32986a0b9
	Issue introduced in 5.6 with commit d2fb0a043838 and fixed in 6.6.15 with commit 7f0ccfad2031
	Issue introduced in 5.6 with commit d2fb0a043838 and fixed in 6.7.3 with commit 9263fd2a6348
	Issue introduced in 5.6 with commit d2fb0a043838 and fixed in 6.8-rc1 with commit f5c24d94512f

Please see https://www.kernel.org or a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2023-52492
will be updated if fixes are backported, please check that for the most
up to date information about this issue.

Affected files
==============

The file(s) affected by this issue are:
	drivers/dma/dmaengine.c

Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/9de69732dde4e443c1c7f89acbbed2c45a6a8e17
	https://git.kernel.org/stable/c/047fce470412ab64cb7345f9ff5d06919078ad79
	https://git.kernel.org/stable/c/2ab32986a0b9e329eb7f8f04dd57cc127f797c08
	https://git.kernel.org/stable/c/7f0ccfad2031eddcc510caf4e57f2d4aa2d8a50b
	https://git.kernel.org/stable/c/9263fd2a63487c6d04cbb7b74a48fb12e1e352d0
	https://git.kernel.org/stable/c/f5c24d94512f1b288262beda4d3dcb9629222fc7