linux-cve-announce - CVE-2025-40346: arch_topology: Fix incorrect error check in topology_parse_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2025121633-CVE-2025-40346-623f@gregkh>
Date: Tue, 16 Dec 2025 14:30:33 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...nel.org>
Subject: CVE-2025-40346: arch_topology: Fix incorrect error check in topology_parse_cpu_capacity()

From: Greg Kroah-Hartman <gregkh@...nel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

arch_topology: Fix incorrect error check in topology_parse_cpu_capacity()

Fix incorrect use of PTR_ERR_OR_ZERO() in topology_parse_cpu_capacity()
which causes the code to proceed with NULL clock pointers. The current
logic uses !PTR_ERR_OR_ZERO(cpu_clk) which evaluates to true for both
valid pointers and NULL, leading to potential NULL pointer dereference
in clk_get_rate().

Per include/linux/err.h documentation, PTR_ERR_OR_ZERO(ptr) returns:
"The error code within @ptr if it is an error pointer; 0 otherwise."

This means PTR_ERR_OR_ZERO() returns 0 for both valid pointers AND NULL
pointers. Therefore !PTR_ERR_OR_ZERO(cpu_clk) evaluates to true (proceed)
when cpu_clk is either valid or NULL, causing clk_get_rate(NULL) to be
called when of_clk_get() returns NULL.

Replace with !IS_ERR_OR_NULL(cpu_clk) which only proceeds for valid
pointers, preventing potential NULL pointer dereference in clk_get_rate().

The Linux kernel CVE team has assigned CVE-2025-40346 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 5.7 with commit b8fe128dad8f97cc9af7c55a264d1fc5ab677195 and fixed in 5.10.246 with commit 64da320252e43456cc9ec3055ff567f168467b37
	Issue introduced in 5.7 with commit b8fe128dad8f97cc9af7c55a264d1fc5ab677195 and fixed in 5.15.196 with commit 02fbea0864fd4a863671f5d418129258d7159f68
	Issue introduced in 5.7 with commit b8fe128dad8f97cc9af7c55a264d1fc5ab677195 and fixed in 6.1.158 with commit a77f8434954cb1e9c42c3854e40855fdcf5ab235
	Issue introduced in 5.7 with commit b8fe128dad8f97cc9af7c55a264d1fc5ab677195 and fixed in 6.6.115 with commit 3373f263bb647fcc3b5237cfaef757633b9ee25e
	Issue introduced in 5.7 with commit b8fe128dad8f97cc9af7c55a264d1fc5ab677195 and fixed in 6.12.56 with commit 45379303124487db3a81219af7565d41f498167f
	Issue introduced in 5.7 with commit b8fe128dad8f97cc9af7c55a264d1fc5ab677195 and fixed in 6.17.6 with commit 3a01b2614e84361aa222f67bc628593987e5cdb2
	Issue introduced in 5.7 with commit b8fe128dad8f97cc9af7c55a264d1fc5ab677195 and fixed in 6.18 with commit 2eead19334516c8e9927c11b448fbe512b1f18a1

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2025-40346
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/base/arch_topology.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/64da320252e43456cc9ec3055ff567f168467b37
	https://git.kernel.org/stable/c/02fbea0864fd4a863671f5d418129258d7159f68
	https://git.kernel.org/stable/c/a77f8434954cb1e9c42c3854e40855fdcf5ab235
	https://git.kernel.org/stable/c/3373f263bb647fcc3b5237cfaef757633b9ee25e
	https://git.kernel.org/stable/c/45379303124487db3a81219af7565d41f498167f
	https://git.kernel.org/stable/c/3a01b2614e84361aa222f67bc628593987e5cdb2
	https://git.kernel.org/stable/c/2eead19334516c8e9927c11b448fbe512b1f18a1