linux-ext4 - e2fsprogs coverity patch <cid-3.diff>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 Feb 2007 18:11:26 -0800
From:	"Brian D. Behlendorf" <behlendorf1@...l.gov>
To:	tytso@....edu
Cc:	linux-ext4@...r.kernel.org, adilger@...sterfs.com,
	behlendorf1@...l.gov, wartens2@...l.gov
Subject: e2fsprogs coverity patch <cid-3.diff>

Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see 
if it would identify any significant bugs.  The analysis
turned up 38 mostly minor issues which are enumerated here
with patches.  We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.

Thanks,
Brian Behlendorf <behlendorf1@...l.gov>, and
Herb Wartens <wartens2@...l.gov>

-----------------------------------------------------------------------------
Coverity ID: 3: Deadcode

blkid_dev_has_tag() will immediately return -1 (an error if value is NULL. Thus
at the test later on value cannot be NULL. There are two possible ways to go
about fixing this. The first would be to remove the first NULL check for value.
The second one would be to remove the second check (and the deadcode). I could
be persuaded either way, but to preserve existing functionality I will opt to
remove the second check.

Index: e2fsprogs+chaos/lib/blkid/tag.c
===================================================================
--- e2fsprogs+chaos.orig/lib/blkid/tag.c
+++ e2fsprogs+chaos/lib/blkid/tag.c
@@ -91,8 +91,6 @@ extern int blkid_dev_has_tag(blkid_dev d
 		return -1;

 	tag = blkid_find_tag_dev(dev, type);
-	if (!value)
-		return(tag != NULL);
 	if (!tag || strcmp(tag->bit_val, value))
 		return 0;
 	return 1;
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html