linux-ext4 - Re: e2fsprogs coverity patch <cid-03.diff>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070318140924.GC14519@thunk.org>
Date:	Sun, 18 Mar 2007 10:09:24 -0400
From:	Theodore Tso <tytso@....edu>
To:	"Brian D. Behlendorf" <behlendorf1@...l.gov>
Cc:	linux-ext4@...r.kernel.org, adilger@...sterfs.com,
	wartens2@...l.gov
Subject: Re: e2fsprogs coverity patch <cid-03.diff>

On Fri, Feb 09, 2007 at 06:11:26PM -0800, Brian D. Behlendorf wrote:
> blkid_dev_has_tag() will immediately return -1 (an error if value is NULL. Thus
> at the test later on value cannot be NULL. There are two possible ways to go
> about fixing this. The first would be to remove the first NULL check for value.
> The second one would be to remove the second check (and the deadcode). I could
> be persuaded either way, but to preserve existing functionality I will opt to
> remove the second check.

Better to do this the other way, I think.  It exposes more
functionality, and there shouldn't be any code that depends on
blkid_dev_has_tag returning an error is value is NULL.

					- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html