linux-ext4 - Re: e2fsprogs coverity patch <cid-4.diff>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070212192530.GM6565@schatzie.adilger.int>
Date:	Mon, 12 Feb 2007 12:25:30 -0700
From:	Andreas Dilger <adilger@...sterfs.com>
To:	"Brian D. Behlendorf" <behlendorf1@...l.gov>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org, wartens2@...l.gov
Subject: Re: e2fsprogs coverity patch <cid-4.diff>

On Feb 09, 2007  18:11 -0800, Brian D. Behlendorf wrote:
> This check is unnecessary since fs_type is guaranteed to be set earlier in the
> function.

I'm not positive this is the right fix.  If we are creating a journal device,
we shouldn't be using the normal defaults based on the size of the journal
device because this will often be much smaller than the actual filesystem.

I'd argue that we set fs_type="journal" earlier when fs_type is being first
set, if INCOMPAT_JOURNAL_DEV is set.

> Index: e2fsprogs+chaos/misc/mke2fs.c
> ===================================================================
> --- e2fsprogs+chaos.orig/misc/mke2fs.c
> +++ e2fsprogs+chaos/misc/mke2fs.c
> @@ -1310,8 +1310,6 @@ static void PRS(int argc, char *argv[])
>  
>  	if (fs_param.s_feature_incompat & 
>  	    EXT3_FEATURE_INCOMPAT_JOURNAL_DEV) {
> -		if (!fs_type)
> -			fs_type = "journal";
>  		reserved_ratio = 0;
>  		fs_param.s_feature_incompat = EXT3_FEATURE_INCOMPAT_JOURNAL_DEV;
>  		fs_param.s_feature_compat = 0;

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html