linux-ext4 - Re: e2fsprogs coverity patch <cid-04.diff>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070319123234.GD14519@thunk.org>
Date:	Mon, 19 Mar 2007 08:32:34 -0400
From:	Theodore Tso <tytso@....edu>
To:	"Brian D. Behlendorf" <behlendorf1@...l.gov>
Cc:	linux-ext4@...r.kernel.org, adilger@...sterfs.com,
	wartens2@...l.gov
Subject: Re: e2fsprogs coverity patch <cid-04.diff>

On Fri, Feb 09, 2007 at 06:11:35PM -0800, Brian D. Behlendorf wrote:
> This check is unnecessary since fs_type is guaranteed to be set earlier in the
> function.
> 
> Coverity ID: 4: Deadcode

The code was actually supposed to be "dead", so in order to restore
the old behavior (from before support for /etc/mke2fs.conf was added)
I needed to move the setting of fs_type of "journal" earlier in the
function.

							- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html