[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4642026D.3040401@redhat.com>
Date: Wed, 09 May 2007 12:18:37 -0500
From: Eric Sandeen <sandeen@...hat.com>
To: Valerie Clement <valerie.clement@...l.net>
CC: "Jose R. Santos" <jrs@...ibm.com>, linux-ext4@...r.kernel.org
Subject: Re: Creating a >32bit blocks filesystem.
Valerie Clement wrote:
> Get the new version of e2fsprogs at
> ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/e2fsprogs-interim/e2fsprogs-1.39-tyt3
> and apply the patchset in attachment.
>
> Hope this helps,
> Valérie
Valérie, this looks a bit odd in 02_use_64bit_io, in debugfs.c:
@@ -149,13 +149,13 @@ void do_open_filesys(int argc, char **ar
data_filename = optarg;
break;
case 'b':
- blocksize = parse_ulong(optarg, argv[0],
+ blocksize = parse_ullong(optarg, argv[0],
"block size", &err);
and same for similar code in main() in debugfs.c.
Surely the block *size* doesn't need to be 64 bits :) I guess that got
accidentally inherited from e2fsprogs-1.39 where blocksize is type
blk_t, which turned into 64 bits now... I think "int" will be fine. :)
Thanks,
-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists