linux-ext4 - Re: [PATCH] uninitialized groups ported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 Jun 2007 13:48:15 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Avantika Mathur <mathur@...ux.vnet.ibm.com>
CC:	Andreas Dilger <adilger@...sterfs.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] uninitialized groups ported - kernel

Avantika Mathur wrote:
> Hi Andreas,
> 
> I have ported your uninitialized block group kernel patch to mainline
> 2.6.22-rc3, included below.
> I will also be posting the ported e2fsprogs patches. I had trouble
> testing the patches because of inconsistency in the block_group
> structure in e2fsprogs - which is only using ext2_block_group, and not
> ext4_block_group.
> 
> Thanks
> Avantika 
> 
> ---

...

> +#if !defined(CONFIG_CRC16) && !defined(CONFIG_CRC16_MODULE)
> +/** CRC table for the CRC-16. The poly is 0x8005 (x16 + x15 + x2 + 1) */
> +__u16 const crc16_table[256] = {
> +	0x0000, 0xC0C1, 0xC181, 0x0140, 0xC301, 0x03C0, 0x0280, 0xC241,
> +	0xC601, 0x06C0, 0x0780, 0xC741, 0x0500, 0xC5C1, 0xC481, 0x0440,


Apologies if this has already been discussed & I missed it, but why 
replicate all this?  why not just require CONFIG_CRC16?

-Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html