linux-ext4 - Re: [PATCH] added sanity check for xattr validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <467AE49D.6030207@redhat.com>
Date:	Thu, 21 Jun 2007 15:50:37 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Andreas Dilger <adilger@...sterfs.com>
CC:	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
	Jim Garlick <garlick@...l.gov>
Subject: Re: [PATCH] added sanity check for xattr validation

Andreas Dilger wrote:
> Ted,
> the attached patch adds an extra validity test in check_ext_attr().  If
> an attribute's e_value_size is zero the current code does not allocate
> a region for it and as a result the e_value_offs value is not verified.
> However, if e_value_offs is very large then the later call to
> ext2fs_ext_attr_hash_entry() can dereference bad memory and crash e2fsck.

Did this patch get lost?  Don't see it in Hg...

Thanks,
-Eric

> Signed-off-by: Andreas Dilger <adilger@...sterfs.com>
> Signed-off-by: Jim Garlick <garlick@...l.gov>
> 
> =========================== e_value_offs.patch ============================
> 
> Index: e2fsprogs-1.39/e2fsck/pass1.c
> ===================================================================
> --- e2fsprogs-1.39.orig/e2fsck/pass1.c	2007-02-10 15:43:36.000000000 +0530
> +++ e2fsprogs-1.39/e2fsck/pass1.c	2007-02-10 15:45:36.000000000 +0530
> @@ -1346,6 +1347,11 @@
>  			if (fix_problem(ctx, PR_1_EA_BAD_VALUE, pctx))
>  				goto clear_extattr;
>  		}
> +		if (entry->e_value_offs + entry->e_value_size > fs->blocksize) {
> +			if (fix_problem(ctx, PR_1_EA_BAD_VALUE, pctx))
> +				goto clear_extattr;
> +			break;
> +		}
>  		if (entry->e_value_size &&
>  		    region_allocate(region, entry->e_value_offs,
>  				    EXT2_EXT_ATTR_SIZE(entry->e_value_size))) {
> =========================== e_value_offs.patch ============================
> 
> Cheers, Andreas
> --
> Andreas Dilger
> Principal Software Engineer
> Cluster File Systems, Inc.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html