linux-ext4 - Re: [PATCH] added sanity check for xattr validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070622062310.GB17097@thunk.org>
Date:	Fri, 22 Jun 2007 02:23:10 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Andreas Dilger <adilger@...sterfs.com>, linux-ext4@...r.kernel.org,
	Jim Garlick <garlick@...l.gov>
Subject: Re: [PATCH] added sanity check for xattr validation

On Thu, Jun 21, 2007 at 03:50:37PM -0500, Eric Sandeen wrote:
> Andreas Dilger wrote:
> > Ted,
> > the attached patch adds an extra validity test in check_ext_attr().  If
> > an attribute's e_value_size is zero the current code does not allocate
> > a region for it and as a result the e_value_offs value is not verified.
> > However, if e_value_offs is very large then the later call to
> > ext2fs_ext_attr_hash_entry() can dereference bad memory and crash e2fsck.
> 
> Did this patch get lost?  Don't see it in Hg...

Thanks, I just committed it.

						-Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html